Skip to content

Split email template and update text #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2021
Merged

Split email template and update text #529

merged 3 commits into from
Sep 1, 2021

Conversation

xxcxy
Copy link
Contributor

@xxcxy xxcxy commented Sep 1, 2021

  1. rendered HTML file url: https://drive.google.com/file/d/1va8u8Qslr8cLRGChE3sqbV_sl1XNr_v4/view?usp=sharing
  2. screenshot:
  1. set these vars in env:
  • NOTIFICATION_CLIENT_VIEWED_PROFILE_SENDGRID_TEMPLATE_ID=1
  • NOTIFICATION_REVIEW_CANDIDATES_SENDGRID_TEMPLATE_ID=2
  • NOTIFICATION_CUSTOMER_INTERVIEW_COMING_UP_SENDGRID_TEMPLATE_ID=3
  • NOTIFICATION_MEMBER_INTERVIEW_COMING_UP_SENDGRID_TEMPLATE_ID=4
  • NOTIFICATION_INTERVIEW_COMPLETE_SENDGRID_TEMPLATE_ID=5
  • NOTIFICATION_POST_INTERVIEW_ACTION_SENDGRID_TEMPLATE_ID=6
  • NOTIFICATION_UPCOMING_RESOURCE_BOOKING_EXPIRATION_SENDGRID_TEMPLATE_ID=7
  • NOTIFICATION_NEW_TEAM_CREATED_SENDGRID_TEMPLATE_ID=8
  • NOTIFICATION_NEW_JOB_ADDED_SENDGRID_TEMPLATE_ID=9
  • NOTIFICATION_RESOURCE_BOOKING_PLACED_SENDGRID_TEMPLATE_ID=10

@xxcxy xxcxy mentioned this pull request Sep 1, 2021
Closed
@xxcxy
Copy link
Contributor Author

xxcxy commented Sep 1, 2021

new verification file: https://drive.google.com/file/d/1zpfy7BDxcwFEY0W0t2UUJRh21vNi_Xfm/view?usp=sharing

maxceem
maxceem suggested changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xxcxy Here are small mismatches I found:

@maxceem
Copy link
Contributor

maxceem commented Sep 1, 2021

@xxcxy one more thing, we don't have to pass description anymore for any email. For example here https://github.com/topcoder-platform/taas-apis/blob/dev/src/services/NotificationsSchedulerService.js#L335 and in other places, as we include it directly into email now.

@xxcxy
Copy link
Contributor Author

xxcxy commented Sep 1, 2021

All done.
btw: I think the workload exceeds $100.

maxceem
maxceem approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xxcxy all works perfectly now.

@maxceem maxceem merged commit 3d9d221 into topcoder-platform:dev Sep 1, 2021
@maxceem
Copy link
Contributor

maxceem commented Sep 1, 2021

btw: I think the workload exceeds $100.

@xxcxy Sure, would be $150 fine + $20 for padding? Or, please, let me know how would you evaluate.

@xxcxy
Copy link
Contributor Author

xxcxy commented Sep 1, 2021

btw: I think the workload exceeds $100.

@xxcxy Sure, would be $150 fine + $20 for padding? Or, please, let me know how would you evaluate.

It's fine. Thank you.

@maxceem maxceem mentioned this pull request Sep 1, 2021
Open
maxceem added a commit that referenced this pull request Sep 2, 2021
@maxceem
Revert "Split email template and update text (#529)"
95b64de 
This reverts commit 3d9d221.
maxceem added a commit that referenced this pull request Sep 2, 2021
@maxceem
Revert "Split email template and update text (#529)"
d0905bb 
This reverts commit 3d9d221.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxceem maxceem maxceem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xxcxy @maxceem